Merge new columns in existing record with default merge strategy #9851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9851 +/- ##
============================================
- Coverage 70.38% 60.66% -9.72%
- Complexity 5013 5321 +308
============================================
Files 1972 1960 -12
Lines 105687 105404 -283
Branches 15988 15987 -1
============================================
- Hits 74383 63940 -10443
- Misses 26109 36743 +10634
+ Partials 5195 4721 -474
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
navina
force-pushed
the
partial-upsert-schema-evolution
branch
from
9c73dd8 to
4c6fc15
Compare
|
@Jackie-Jiang / @KKcorps : please review! |
KKcorps
reviewed
Nov 24, 2022
...-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
Show resolved
Hide resolved
KKcorps
approved these changes
Nov 28, 2022
Jackie-Jiang
approved these changes
Nov 28, 2022
...-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
Outdated
Show resolved
Hide resolved
...-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/PartialUpsertHandler.java
Outdated
Show resolved
Hide resolved
navina
force-pushed
the
partial-upsert-schema-evolution
branch
from
4c6fc15 to
e0a3687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #9771
After a schema evolves (eg. new column added), the column is not treated as an upsert column by the partition upsert manager because it is not part of
PartialUpsertHandler#column2Mergers. This PR attempts to fix this by iterating through all columns in the record and applying a default merge strategy on all columns, except primary key and comparison column.Note: This PR can handle schema evolution of adding new columns without restarting the server, as long as there are no changes to the upsert config. Any change made to the
upsertConfig: {}section in the table config of a partial upsert enabled table will require a server restart to correctly reload all segments and the metadata.Labels:
bugfix